-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EN language support for skills added by Midnight's Rebalance Mod #147
Conversation
Thanks for the PR @AristocratMC, can you remove the mod-specific skill IDs from this? if not, I can commit just the vanilla changes. I'll look into seeing how I can support adding new skill IDs for mods, it's close with the |
…, and Id in Midnight's Rebalance Mod" This reverts commit 380fdd6.
Sure, I have reverted the mod-specific things in fcdcdda. I also did another pass on the EN labels to make them a bit more consistent.
That would be great to have if it gets implemented, it will solve the use case of reading modded parses without requiring everyone to install some other fork. Thanks again for all the work you've done on GBFR Logs, it's been a literal gamechanger. |
I attempted to do this as a
ui.json
-only localization patch, but skill groupings are defined viaassets\skill-groups.ts
which must be compiled into the executable, so I raised a pull request.Fix (for vanilla skills)
Added (for non-vanilla skills)