Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EN language support for skills added by Midnight's Rebalance Mod #147

Merged
merged 17 commits into from
Jul 5, 2024

Conversation

AristocratMC
Copy link
Contributor

I attempted to do this as a ui.json-only localization patch, but skill groupings are defined via assets\skill-groups.ts which must be compiled into the executable, so I raised a pull request.

Fix (for vanilla skills)

  • Rackam's BEB
  • Id's Reginleiv & Godmight Finisher

Added (for non-vanilla skills)

  • Rosetta's Combo Finisher & Attack 5
  • Vane's shortcutted Beatdown & post-skill Finisher 3
  • Vaseraga's instant Finisher 2
  • Zeta's Realm's Majesty Counter & follow-up Hammer
  • Id's Godmight Perfect Combo & mistimed combo/finishers grouping

@false-spring
Copy link
Owner

false-spring commented Jul 4, 2024

Thanks for the PR @AristocratMC, can you remove the mod-specific skill IDs from this? if not, I can commit just the vanilla changes.

I'll look into seeing how I can support adding new skill IDs for mods, it's close with the ui.json patch but skill groups also needs to be pulled out into a JSON file as well.

@AristocratMC
Copy link
Contributor Author

Thanks for the PR @AristocratMC, can you remove the mod-specific skill IDs from this? if not, I can commit just the vanilla changes.

Sure, I have reverted the mod-specific things in fcdcdda. I also did another pass on the EN labels to make them a bit more consistent.

I'll look into seeing how I can support adding new skill IDs for mods, it's close with the ui.json patch but skill groups also needs to be pulled out into a JSON file as well.

That would be great to have if it gets implemented, it will solve the use case of reading modded parses without requiring everyone to install some other fork. Thanks again for all the work you've done on GBFR Logs, it's been a literal gamechanger.

@false-spring false-spring self-requested a review July 5, 2024 03:04
@false-spring false-spring merged commit cc0b18f into false-spring:main Jul 5, 2024
4 of 5 checks passed
@false-spring false-spring added this to the 1.8.0 milestone Jul 5, 2024
@false-spring false-spring mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants