Skip to content

Build as shared library #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2014
Merged

Build as shared library #12

merged 4 commits into from
Feb 14, 2014

Conversation

frysztak
Copy link
Contributor

Sorry I didn't make those changes before previous pull request.

@fallahn
Copy link
Owner

fallahn commented Feb 13, 2014

I'm having a think about this - there's not really a problem but the helpers and debugshape files are actually from a framework I maintain separately, and moving them here affects the file structure of the framework. Bad planning by me really, I'll look into reorganising my framework structure.

@frysztak
Copy link
Contributor Author

Well, I realise it's kind of rude of me to just march in and reorganise your work. But the reason I did this is because I wanted to keep the package clean. Orignally, DebugShape.h and Helpers.h would be in /usr/include which is really ugly and out-of-place. I don't know if you ever intended your library to be packaged, but I find it very comfortable and more flexible.

@fallahn
Copy link
Owner

fallahn commented Feb 13, 2014

Not at all, the dependencies should be all kept together, I agree. Unfortunately I have other things which depend on these two files. Ideally I want to merge this - I just have to first work out how I'll break my Windows habits :)

fallahn added a commit that referenced this pull request Feb 14, 2014
@fallahn fallahn merged commit 39b4a5c into fallahn:master Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants