-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send confirmation email for registration #249
base: devel
Are you sure you want to change the base?
Conversation
Is this a WIP PR? Because there's still some tests breaking in the CI tool. |
Now the PR is complete. Now there is the versioning of endpoint /users, where in v1/users email confirmation is required to register new users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this look ok to me, I just didn't get why there are so many templates that apparently do the same thing. Might be just a technicality tho ¯_(ツ)_/¯
For some reason when I delete templates from the user_mailer folder I get a missing template error. The same happens when I remove templates from the layouts folder. Keeping the two template folders all works beautifully ¯_(ツ)_/¯ By the way, sending emails is using Sendgrid. It would be interesting for a project maintainer to create a Sendgrid account and add the key to the environment.rb file on deploy. |
Hey @alaxalves, I added some exceptions, could you review again? |
Proposed Changes
Upon registration, the system sends an email to the user to confirm their registration.
Type of Change
What kind of changes this Pull Request introduces to Falko?
Checklist
Other Comments
When creating a new version of the user address, email confirmation is required, so a new version has been created as V1/users. The versioning of the whole API is something that is beyond the scope of this issue, so we opted for the above.
Close #214