US21 - Manter Nota #175
Merged
US21 - Manter Nota #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com> Signed-off-by: Mateus097 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
|
Acredito que a solução pra esse erro seria agrupar os atributos semelhantes em um objeto apenas, porém iríamos perder em legibilidade. Vou ignorar essa issue. |
Signed-off-by: Mateus097 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
…ackEnd into US21_manter_nota
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
pedrokelvin
force-pushed
the
US21_manter_nota
branch
from
10e3b72
to
1fcd6d5
Compare
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com> Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com> Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com> Signed-off-by: MartinsLucas <lucas465@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com> Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com> Signed-off-by: danieloda <danieloda35@gmail.com>
…ko-2017.2-BackEnd into US21_manter_nota
…2-BackEnd into US21_manter_nota
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com> Signed-off-by: MartinsLucas <lucas465@hotmail.com>
…ackEnd into US21_manter_nota
…2-BackEnd into US21_manter_nota
…ko-2017.2-BackEnd into US21_manter_nota
alaxalves
requested changes
Dec 13, 2017
app/controllers/grades_controller.rb
Outdated
| # begin | ||
| final_metric = get_metrics(@grade) | ||
| render json: final_metric | ||
| # rescue HasNoSprints |
There was a problem hiding this comment.
pq vcs comentaram isso ??
There was a problem hiding this comment.
A gente tava fazendo uns testes pra lançar exceção mas não deu certo. Vou retirar
test/models/grade_test.rb
Outdated
|
|
||
| @project = Project.create( | ||
| name: "Falko", | ||
| description: "Esse projeto faz parte da disciplina MDS.", |
There was a problem hiding this comment.
E isso aqui em portugues??
test/models/grade_test.rb
Outdated
|
|
||
| @sprint = Sprint.create( | ||
| name: "Sprint1", | ||
| description: "Essa sprint", |
| ) | ||
|
|
||
| @has_grade_project = Project.create( | ||
| name: "Futebol", |
| @@ -76,6 +86,20 @@ def validate_project(id, project_id) | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
| def validate_grade(id, grade_id) | |||
There was a problem hiding this comment.
@pedrokelvin Digue que id é esse?
alaxalves
force-pushed
the
US21_manter_nota
branch
from
6516ccf
to
11e11cd
Compare
alaxalves
force-pushed
the
US21_manter_nota
branch
from
159ca56
to
f97b492
Compare
…-BackEnd into US21_manter_nota Signed-off-by: Álax Alves <alaxallves@gmail.com>
alaxalves
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mudanças Propostas
História de usuário Manter Nota
Tipo de Mudança
Que tipo de mudanças este Pull Request introduz ao Falko?
Marque um
xao que se aplicarChecklist
Marque um
xao que se aplicar. Se você não tiver certeza sobre algum dos tópicos, não hesite em perguntar. Estamos aqui para ajudar!Outros Comentários