Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US21 - Manter Nota #175

Merged
merged 46 commits into from
Dec 13, 2017
Merged

US21 - Manter Nota #175

merged 46 commits into from
Dec 13, 2017

Conversation

pedrokelvin
Copy link
Collaborator

@pedrokelvin pedrokelvin commented Dec 10, 2017

Mudanças Propostas

História de usuário Manter Nota

Tipo de Mudança

Que tipo de mudanças este Pull Request introduz ao Falko?
Marque um x ao que se aplicar

  • Conserto de Bug
  • Nova Feature

Checklist

Marque um xao que se aplicar. Se você não tiver certeza sobre algum dos tópicos, não hesite em perguntar. Estamos aqui para ajudar!

  • O nome do pull request deve ser auto-explicativo e deve estar em português.
  • Os commits seguem a política de commits do repositório.
  • Não há erros no rubocop.
  • A build está passando (testes, code climate e codacy).
  • O pull request está linkado à uma issue existente.
  • Foram criados seeds para as novas User Stories.

Outros Comentários

pedrokelvin and others added 7 commits December 5, 2017 09:24
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com>
Signed-off-by: Mateus097 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
@alaxalves
Copy link
Collaborator

image

Acredito que a solução pra esse erro seria agrupar os atributos semelhantes em um objeto apenas, porém iríamos perder em legibilidade. Vou ignorar essa issue.

pedrokelvin and others added 8 commits December 11, 2017 16:42
Signed-off-by: Mateus097 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
pedrokelvin and others added 7 commits December 12, 2017 19:57
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: danieloda <danieloda35@gmail.com>
Signed-off-by: Pedro Kelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MartinsLucas <lucas465@hotmail.com>
Signed-off-by: pedrokelvin <pedrokelvin2006@gmail.com>
Signed-off-by: MateusO97 <mat97_@hotmail.com>
@alaxalves alaxalves changed the title Us21 manter nota US21 - Manter Nota (In Progress) Dec 13, 2017
# begin
final_metric = get_metrics(@grade)
render json: final_metric
# rescue HasNoSprints
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq vcs comentaram isso ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A gente tava fazendo uns testes pra lançar exceção mas não deu certo. Vou retirar


@project = Project.create(
name: "Falko",
description: "Esse projeto faz parte da disciplina MDS.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E isso aqui em portugues??


@sprint = Sprint.create(
name: "Sprint1",
description: "Essa sprint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portugues :D

)

@has_grade_project = Project.create(
name: "Futebol",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portuguessss

@@ -76,6 +86,20 @@ def validate_project(id, project_id)
end
end


def validate_grade(id, grade_id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que id é esse?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrokelvin Digue que id é esse?

…-BackEnd into US21_manter_nota

Signed-off-by: Álax Alves <alaxallves@gmail.com>
@alaxalves alaxalves changed the title US21 - Manter Nota (In Progress) US21 - Manter Nota Dec 13, 2017
@alaxalves alaxalves merged commit b420b47 into devel Dec 13, 2017
@alaxalves alaxalves deleted the US21_manter_nota branch December 13, 2017 23:43
This was referenced Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants