Fix plugin config init config template #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add dummy InitConfig to dummy test to force init config templating logic to run.
Fix the PluginConfigInfo InitiConfig templating to use exported function and directly call it.
This fix is necessary to for example test Falco rules using this pkg when plugins such as the k8smeta plugin are required as the plugin has a few required init config fields.
WHY
The go template logic requires the the field to be exported in order to be able to render it. For unexported fields we otherwise see an error like this:
Similarly it seems that for struct functions evaluating to string the template pkg seems to treat them as fields. So using the
callkeyword results in the below error:Thus fixing this requires exporting the function and removing the
callkeyword. This can be verified by running theTestDummy_PrometheusMetricstest while 1e56096 is checked out.