chore(userspace/libscap): give name to bpf programs #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
do-not-merge/work-in-progress
kind/feature
alban
force-pushed
the
alban_bpf_prog_name
branch
from
336774e to
722d41f
Compare
FedeDP
reviewed
Aug 25, 2022
| /* 'event' looks like "raw_tracepoint/raw_syscalls/sys_enter". Skip | ||
| * two '/' to find the last word, if possible. | ||
| */ | ||
| prog_name = strstr(event, "/"); |
There was a problem hiding this comment.
I'd use strrchr instead, that automatically fetches last occurrence of '/'.
Then, if anything is found, we can use just prog_name++.
Andreagit97
reviewed
Aug 25, 2022
| @@ -513,6 +517,7 @@ static int32_t load_tracepoint(struct bpf_engine* handle, const char *event, str | |||
| int err; | |||
| int fd; | |||
| int id; | |||
| const char *prog_name; | |||
There was a problem hiding this comment.
I know it is super useless but it is future-proof 😆!
Suggested change
| const char *prog_name; | |
| const char *prog_name = NULL; |
This patch helps to distinguish Falco's bpf programs in bpftool or in 'kubectl gadget top ebpf'. Signed-off-by: Alban Crequy <albancrequy@microsoft.com>
alban
force-pushed
the
alban_bpf_prog_name
branch
from
722d41f to
38ba7bd
Compare
|
Tested in Falco (on branch falcosecurity/falco#2177) with the following: And in another terminal: |
|
Very nice! Thanks! |
|
LGTM label has been added. Git tree hash: 8598634c444118075ad30f625a0359f18f860bd0
|
FedeDP
approved these changes
Aug 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alban, Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tested with Falco, the bpf programs names are now visible in Inspektor Gadget's top-ebpf tool: |
|
Wow this is super useful, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This patch helps to distinguish Falco's bpf programs in bpftool or in kubectl gadget top ebpf.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: