Make installing files during install configurable #338
Conversation
poiana
added
release-note
dco-signoff: yes
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mstemm
force-pushed
the
skip-libs-deps-install
branch
from
cc8020d to
fec19c0
Compare
|
Thank you mark! This makes sense to me. |
|
I wished there was a more elegant way to achieve this though :( |
A |
Some users of libs use its cmake files directly via an include() directive. By doing that, those users inherit any install() directives in the libs CMakeFiles. Prior to the changes in #247, libs did not actually have any install() directives, but now that it does, the users of libs end up getting libsinsp/libscap as well as all of its dependencies installed as well, which may not be what they want. To allow for both use cases, have install()s controlled by an option INSTALL_LIBS, which defaults to ON. Any users of libs that want to use the cmake files and that don't want anything installed can set this option to OFF. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
mstemm
force-pushed
the
skip-libs-deps-install
branch
from
fec19c0 to
e556dc0
Compare
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh with Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue with Mark the issue as fresh with Provide feedback via https://github.com/falcosecurity/community. |
|
@poiana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Some users of libs use its cmake files directly via an include()
directive. By doing that, those users inherit any install() directives
in the libs CMakeFiles.
Prior to the changes in
#247, libs did not actually
have any install() directives, but now that it does, the users of libs
end up getting libsinsp/libscap as well as all of its dependencies
installed as well, which may not be what they want.
To allow for both use cases, have install()s controlled by an option
INSTALL_LIBS, which defaults to ON. Any users of libs that want to use
the cmake files and that don't want anything installed can set this
option to OFF.
Signed-off-by: Mark Stemm mark.stemm@gmail.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: