Skip incomplete container info for container start #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
force-pushed
the
skip-incomplete-container-started
branch
2 times, most recently
from
2cc6c64 to
be46944
Compare
In the container_started macro, ensure that the container metadata is complete after either the container event (very unlikely) or after the exec of the first process into the container (very likely now that container metadata fetches are async). When using these rules with older falco versions, this macro will still work as the synchronous container metadata fetch will result in a repository that isn't "incomplete".
mstemm
force-pushed
the
skip-incomplete-container-started
branch
from
be46944 to
5e438d8
Compare
Some test trace files used for regression tests didn't have full container info, and once we started looking for those fields, the tests stopped working. So update the traces, and event counts to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the container_started macro, ensure that the container metadata is
complete after either the container event (very unlikely) or after the
exec of the first process into the container (very likely now that
container metadata fetches are async).
When using these rules with older falco versions, this macro will still
work as the synchronous container metadata fetch will result in a
repository that isn't "incomplete".