-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): allow each metric output channel to be selected independently #3232
fix(metrics): allow each metric output channel to be selected independently #3232
Conversation
…dently Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
/milestone 0.39.0 |
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@@ -93,15 +93,15 @@ std::string falco_metrics::to_text(const falco::app::state& state) | |||
{ | |||
fs::path fs_path = item.first; | |||
std::string metric_name_file_sha256 = fs_path.filename().stem(); | |||
metric_name_file_sha256 = "falco.sha256_rules_file." + falco::utils::sanitize_metric_name(metric_name_file_sha256); | |||
metric_name_file_sha256 = "falco_sha256_rules_file_" + falco::utils::sanitize_metric_name(metric_name_file_sha256); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a super small regression I must have introduced in the last PR. We will push some better checks and sanitizing the metrics name into libs in the upcoming dev cycle, already tracking it in our issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I thought I saw this dot that look out of place but somehow missed to ask about it...
I think we should add a more thorough test of the output content to avoid such regression in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, plus even push more checks into libs for which we didn't have time anymore. It's tracked on that one issue we have.
/milestone 0.38.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: d5e3d317aa7925f1628268084cf03f00e142888a
|
@@ -93,15 +93,15 @@ std::string falco_metrics::to_text(const falco::app::state& state) | |||
{ | |||
fs::path fs_path = item.first; | |||
std::string metric_name_file_sha256 = fs_path.filename().stem(); | |||
metric_name_file_sha256 = "falco.sha256_rules_file." + falco::utils::sanitize_metric_name(metric_name_file_sha256); | |||
metric_name_file_sha256 = "falco_sha256_rules_file_" + falco::utils::sanitize_metric_name(metric_name_file_sha256); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I thought I saw this dot that look out of place but somehow missed to ask about it...
I think we should add a more thorough test of the output content to avoid such regression in the future.
@sgaist: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
See #3229 (comment)
CC @sboschman
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: