Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts/falco-driver-loader): fixed ubuntu kernel version #2635

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix(scripts/falco-driver-loader): fixed ubuntu kernel version #2635

merged 1 commit into from
Jun 22, 2023

Conversation

therealbobo
Copy link
Contributor

@therealbobo therealbobo commented Jun 12, 2023 •
edited by FedeDP
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This corrects the kernel_version parsing for ubuntu flavors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(driver-loader): fix ubuntu kernel version parsing

@poiana poiana requested review from FedeDP and Kaizhe June 12, 2023 15:07
@poiana poiana added the size/XS label Jun 12, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Jun 12, 2023

/hold

@therealbobo therealbobo force-pushed the fix/driver-loader-ubuntu branch 4 times, most recently from e8e0bca to 2dbace3 Compare June 12, 2023 15:52
@FedeDP FedeDP mentioned this pull request Jun 13, 2023
Merged
@therealbobo therealbobo force-pushed the fix/driver-loader-ubuntu branch 5 times, most recently from c72351f to 67ea7ce Compare June 13, 2023 08:52
FedeDP
FedeDP reviewed Jun 13, 2023
View reviewed changes
scripts/falco-driver-loader
@@ -169,10 +169,15 @@ get_target_id() {
# 5.15.0-1009-aws -> ubuntu-aws
if [[ $KERNEL_RELEASE =~ -([a-zA-Z]+)(-.*)?$ ]];
then
TARGET_ID="ubuntu-${BASH_REMATCH[1]}${BASH_REMATCH[2]}"
TARGET_ID="ubuntu-${BASH_REMATCH[1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will only use -aws here (without eventual -5.19 suffix)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the above example!

@FedeDP
Copy link
Contributor

FedeDP commented Jun 13, 2023

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Jun 13, 2023
@therealbobo therealbobo force-pushed the fix/driver-loader-ubuntu branch from 67ea7ce to 5cb8ebe Compare June 13, 2023 10:01
@poiana poiana added size/S and removed size/XS labels Jun 13, 2023
@therealbobo therealbobo force-pushed the fix/driver-loader-ubuntu branch 2 times, most recently from 9ce5b67 to 3a00893 Compare June 13, 2023 10:04
FedeDP
FedeDP approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 13, 2023
@poiana
Copy link
Contributor

poiana commented Jun 13, 2023

LGTM label has been added.

Git tree hash: cfd22b5489f440bb7fd7bd003c9155a6365b68a8

@FedeDP
Copy link
Contributor

FedeDP commented Jun 13, 2023

/hold

@jasondellaluce jasondellaluce mentioned this pull request Jun 21, 2023
Closed
43 tasks
@jasondellaluce
Copy link
Contributor

/milestone 0.35.1

@poiana poiana modified the milestones: 0.36.0, 0.35.1 Jun 21, 2023
@jasondellaluce
Copy link
Contributor

CI Build / test-dev-packages (static) / test-packages (pull_request)

This job is probably failing because the PR branch is based on a base commit that still didn't solve all issues. My guess is that by just rebasing on master all tests should pass.

@therealbobo
fix(scripts/falco-driver-loader): fixed ubuntu kernel version
733c788 
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@therealbobo therealbobo force-pushed the fix/driver-loader-ubuntu branch from 3a00893 to 733c788 Compare June 22, 2023 10:19
@poiana poiana removed the lgtm label Jun 22, 2023
@poiana poiana requested a review from FedeDP June 22, 2023 10:19
FedeDP
FedeDP approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 22, 2023
@poiana
Copy link
Contributor

poiana commented Jun 22, 2023

LGTM label has been added.

Git tree hash: 665471aee74a1378d1de2ae26fdbb0ce82f38a1e

jasondellaluce
jasondellaluce approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jun 22, 2023

/unhold

@poiana poiana merged commit c2af4c3 into falcosecurity:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved dco-signoff: yes kind/bug lgtm release-note size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.35.1
Development

Successfully merging this pull request may close these issues.
4 participants
@therealbobo @FedeDP @poiana @jasondellaluce