update: add missing exception, required_engine_version, required_plugin_version to -L json output #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just waiting for a plugin bump to 3.0.0 to finish testing it |
loresuso
force-pushed
the
update-json-outpu
branch
4 times, most recently
from
0e31ef5 to
9a08691
Compare
There was a problem hiding this comment.
Thanks Lore! Two things missing before a LGTM:
- The block at line 581 needs to be reworked to use
create_formatter(r.source, r.output), so that the engine creates the formatter with the wrong source. This is blocked by chore(userspace/libsinsp): make get_field_names a property of generic formatters libs#1120, otherwise we'd be forced to do dynamic casting which would be gross. - When a rule/macro match all the event types, return all the types instead of an empty sequence (makes life sooo much easier on automatic checkers)
|
/milestone 0.35.0 |
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
…ugin_versions and exception names to -L output Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
loresuso
force-pushed
the
update-json-outpu
branch
3 times, most recently
from
1fcb201 to
9ff134f
Compare
loresuso
changed the title
loresuso
force-pushed
the
update-json-outpu
branch
from
9ff134f to
256a439
Compare
|
@loresuso can you add a release note? |
FedeDP
reviewed
May 29, 2023
loresuso
force-pushed
the
update-json-outpu
branch
from
256a439 to
e176736
Compare
|
LGTM label has been added. Git tree hash: 0bebc9dfa46d7d32a2082aa1eb5162024eb2c2fb
|
|
/hold for @jasondellaluce to review! |
LucaGuerra
reviewed
May 29, 2023
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
loresuso
force-pushed
the
update-json-outpu
branch
from
e176736 to
bdeb313
Compare
|
LGTM label has been added. Git tree hash: 390c8f1362da1d040f2b619aa2ef8a69bd0f020d
|
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As per PR title
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: