Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync falco 0.34.1 #2422

Merged
merged 3 commits into from
Feb 17, 2023
Merged

sync falco 0.34.1 #2422

merged 3 commits into from
Feb 17, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Feb 16, 2023 •
edited by Andreagit97
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This PR cherrypicks the commits introduced by the following PRs:

to release/0.34.x branch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

alacuku and others added 2 commits February 16, 2023 10:12
@alacuku
fix(dockerfile/no-driver): install ca-certificates
ed2e9fe 
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@loresuso @alacuku
fix(userspace/engine): correctly bump engine version after introducti…
9b50165 
…on of new fields

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@poiana poiana requested review from Kaizhe and leogr February 16, 2023 09:18
@poiana poiana added the size/XS label Feb 16, 2023
@alacuku
Copy link
Member Author

alacuku commented Feb 16, 2023

#2421

Andreagit97
Andreagit97 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Feb 16, 2023
@poiana
Copy link
Contributor

poiana commented Feb 16, 2023

LGTM label has been added.

Git tree hash: c354710436078f6bc217a1bcc4f8bd5cf7e303e3

@alacuku alacuku mentioned this pull request Feb 16, 2023
Closed
22 tasks
@alacuku
Copy link
Member Author

alacuku commented Feb 16, 2023

/hold
I wait for libs to be tagged and bump the version into Falco.

@alacuku
update(cmake): bumped libs to 0.10.4
84ab408 
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@poiana poiana removed the lgtm label Feb 17, 2023
@poiana poiana requested a review from Andreagit97 February 17, 2023 10:57
@alacuku
Copy link
Member Author

alacuku commented Feb 17, 2023

/unhold
Libs version has been bumped.

Andreagit97
Andreagit97 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Feb 17, 2023
@poiana
Copy link
Contributor

poiana commented Feb 17, 2023

LGTM label has been added.

Git tree hash: c95ae16af4d9289daa7d2bd20b3804d1938880ec

jasondellaluce
jasondellaluce approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9a4205c into falcosecurity:release/0.34.x Feb 17, 2023
@leogr
Copy link
Member

leogr commented Feb 17, 2023

/milestone 0.34.1

@poiana poiana added this to the 0.34.1 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@leogr leogr Awaiting requested review from leogr

Assignees

@jasondellaluce jasondellaluce

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/release lgtm release-note-none size/XS
Projects
None yet
Milestone
0.34.1
Development

Successfully merging this pull request may close these issues.
6 participants
@alacuku @poiana @leogr @jasondellaluce @Andreagit97 @loresuso