doc(userspace): provide users with a correct message when some syscalls are not defined #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
FedeDP
reviewed
Dec 16, 2022
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
|
/milestone 0.34.0 |
|
LGTM label has been added. Git tree hash: adab53f22ae55502da22b2f74bf3dc5ff4ccdc68
|
leogr
approved these changes
Dec 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind documentation
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As reported by @happy-dude here #2326, when running Falco on
aarch64, Falco logs a misleading error message. Take as an example the issue log:All these syscalls are not defined on
aarch64architectures but Falco is not yet able to detect it! As a first step, I would fix the log just to let the user know what is happening under the hood. Obviously, this is not the final solution, which will require some changes in the libraries to detect this sort of behavior, for this reason, the final fix will be shipped only inFalco 0.35Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: