Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: detecting executions looking for AWS credentials #2224

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

AlbertoPellitteri
Copy link
Contributor

@AlbertoPellitteri AlbertoPellitteri commented Sep 27, 2022

Signed-off-by: Alberto Pellitteri albertopellitteri96@gmail.com
Co-authored-by: Alessandro Brucato alessandro.brucato@sysdig.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Nowadays many attacks are interested in stealing credentials. Most of the researched credentials are related to cloud platforms and can used by attackers to attempt lateral movement attacks. TeamTNT, for example, is a well-known threat actor that continuously conducts campaigns to steal AWS related credentials.
For this reason we created the Find AWS credentials rule, able to detect whenever a process searches the AWS credential file or keywords related to AWS secret key or access key.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Find AWS Credentials): new rule to detect executions looking for AWS credentials

@jasondellaluce
Copy link
Contributor

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Oct 3, 2022
@darryk10
Copy link
Contributor

Thanks @AlbertoPellitteri for the contribution. From my point of view the rule is pretty specific and testing the rule it doesn't introduce noise. Great contribution.

darryk10
darryk10 previously approved these changes Oct 12, 2022
Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link
Contributor

poiana commented Oct 12, 2022

LGTM label has been added.

Git tree hash: 64a1ae5ac6e27a337a43093415d2d5fdcbb3f2c0

leogr
leogr previously approved these changes Dec 12, 2022
@jasondellaluce
Copy link
Contributor

This LGTM, @AlbertoPellitteri can you rebase it on top of master?

@leogr leogr dismissed stale reviews from darryk10 and themself via 0786b29 December 15, 2022 15:19
@leogr leogr force-pushed the find_grep_aws_creds branch from 0f1f0b1 to 0786b29 Compare December 15, 2022 15:19
@poiana poiana removed the lgtm label Dec 15, 2022
@poiana poiana requested review from darryk10 and leogr December 15, 2022 15:19
@poiana poiana removed the approved label Dec 15, 2022
leogr
leogr previously approved these changes Dec 15, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased.
Re-approved.
👍

@poiana poiana added the lgtm label Dec 15, 2022
@poiana
Copy link
Contributor

poiana commented Dec 15, 2022

LGTM label has been added.

Git tree hash: 9f1383420e27ae3f89d6b1f6485c14505fe75391

darryk10
darryk10 previously approved these changes Dec 15, 2022
FedeDP
FedeDP previously approved these changes Dec 15, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Signed-off-by: Alberto Pellitteri <albertopellitteri96@gmail.com>
Co-authored-by: Alessandro Brucato <alessandro.brucato@sysdig.com>
@leogr leogr dismissed stale reviews from FedeDP, darryk10, and themself via 7bbf76f December 16, 2022 08:57
@leogr leogr force-pushed the find_grep_aws_creds branch from 0786b29 to 7bbf76f Compare December 16, 2022 08:57
@poiana poiana removed the lgtm label Dec 16, 2022
@poiana poiana requested review from darryk10, FedeDP and leogr December 16, 2022 08:57
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased.
Reapproved.

ping @FedeDP

@poiana poiana added the lgtm label Dec 16, 2022
@poiana
Copy link
Contributor

poiana commented Dec 16, 2022

LGTM label has been added.

Git tree hash: e8256b27bf34f50e73e10d12caa58b34d72a8d1a

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlbertoPellitteri, FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 68b87a6 into falcosecurity:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants