Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme update and plugins #1940

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 15, 2022

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

Adding plugin references to the documentation plus some minor improvements.

Which issue(s) this PR fixes:

Special notes for your reviewer:

I haven't added a link to the plugin-sdk-cpp since it does not yet seem to be mature enough.

Does this PR introduce a user-facing change?:

NONE

leogr and others added 4 commits March 15, 2022 10:20
I am co-authoring original authors to keep their credits.

Co-Authored-by: Kris Nova <kris@nivenly.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Massimiliano Giovagnoli <massimiliano.giovagnoli.1992@gmail.com>
Co-Authored-By: Jonah Jones <jonahjones094@gmail.com>
Co-Authored-By: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link
Contributor

poiana commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented Mar 15, 2022

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Mar 15, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

👍🏼

Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd still include the c++ plugin sdk even though we expect more people to use the go one. But I think there are other ways to learn about the c++ sdk so it's ok w/ me to only include the go one here.

@poiana poiana merged commit 31111ab into master Mar 17, 2022
@poiana poiana deleted the docs/readme-update-and-plugins branch March 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants