Better handle not having a config file #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibalizer
force-pushed
the
fix_1406
branch
3 times, most recently
from
05300eb to
2249afa
Compare
leogr
reviewed
Nov 25, 2020
Fixes: falcosecurity#1406 Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
leogr
approved these changes
Dec 9, 2020
|
LGTM label has been added. Git tree hash: a2b6bc20469674478f2d0fc3575f8b15ddeff8d1
|
fntlnz
approved these changes
Dec 10, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.27.0 |
|
Updated the release notes indicating that this is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1406
Signed-off-by: Spencer Krum nibz@spencerkrum.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
When there is a config file that can't be read and a command line config set, that can create a seg fault. Instead of supporting the use case where the user doesn't have a config file, force the user to provide a config file and stop supporting a no-config-file case.
Which issue(s) this PR fixes:
Fixes # 1406
Special notes for your reviewer:
Does this PR introduce a user-facing change?: