-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(userspace/falco): print version at startup #1303
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!
Anyway, I have a question.
Why do not stick with the usual two-line version (line 626-627) logs we use for the --version
flag in order to be more consistent?
There's a particular reason to print Falco version and driver version this way when Falco runs?
Lines 626-627 uses |
I don't have particular preferences honestly. I was just asking if there was a ratio behind putting both versions on the same line. That's all! |
LGTM label has been added. Git tree hash: b0db7668fb16d54f0db4053d64d0e429d0647fc0
|
Moving this to next release because it hasn't reached 2 approvals /milestone 0.25.0 |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Approved, I think we can get this in now! |
/hold cancel |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
See #1302
Which issue(s) this PR fixes:
Fixes #1302
Special notes for your reviewer:
/milestone 0.24.0
/cc @fntlnz
/cc @leodido
/cc @kris-nova
Does this PR introduce a user-facing change?: