Create a macro to whitelist terminal usage in containers #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate the macro A macro like this is useful because configuration management software may need to run containers with an attached terminal to perform some of its duties, and users may want to ignore this behavior. Signed-off-by: Nicolas Marier <nmarier@coveo.com>
marier-nico
changed the title
|
/lgtm |
leodido
approved these changes
Jun 23, 2020
|
LGTM label has been added. Git tree hash: 23602b911f986cdcf63b3bfffa9be76643297da9
|
fntlnz
approved these changes
Jun 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This PR simply adds a macro to allow exclusion conditions to be set for the
Terminal shell in containerrule. There are some use-cases under which this is normal and should be ignored. For example, some configuration management tools can be run inside docker and operate with an interactive terminal. Falco generates an alert from this, but it's expected to happen for the configuration manager, so it would be nice to be able to whitelist just the configuration management tool.Which issue(s) this PR fixes:
No issues open for this.
Does this PR introduce a user-facing change?: