-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(userspace/falco): add --disable-cri-async flag #1099
Conversation
c813e4d
to
e2cc599
Compare
/milestone 0.22.0 |
Signed-off-by: Lorenzo Fontana <lo@linux.com>
e2cc599
to
dd20275
Compare
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold hold this until 0.21.0 is cut |
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: 169e6e276b6efc0f12af311cc8df6c350ca84c09
|
/hold cancel |
Artifacts to try this can be found here in the meanwhile this gets merged: https://854-49986046-gh.circle-artifacts.com/0/packages/falco-0.20.0-60%2Bdd20275-x86_64.deb |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kris-nova, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there any changes on how we are going to build binary and deploy? |
Hey @nebi-frame you can grab the packages from: |
Hey, so after testing this, we are able to confirm that for ECS isntances, this fix has been resolved. However, on our EKS instances, the issue continues to persist. Could you please help us identify why that might be? I confirmed that we installed the latest falco and that it is running with this new flag. Thanks! |
Signed-off-by: Lorenzo Fontana lo@linux.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #925
Special notes for your reviewer:
Does this PR introduce a user-facing change?: