Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(userspace/falco): add --disable-cri-async flag #1099

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Mar 17, 2020

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #925

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new: flag to disable asynchronous container metadata (CRI) fetch `--disable-cri-async`

@poiana poiana requested review from leodido and mfdii March 17, 2020 14:26
@poiana poiana added the size/S label Mar 17, 2020
@fntlnz fntlnz force-pushed the feat/cri-async-flag branch 2 times, most recently from c813e4d to e2cc599 Compare March 17, 2020 14:33
@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 17, 2020

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Mar 17, 2020
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the feat/cri-async-flag branch from e2cc599 to dd20275 Compare March 17, 2020 14:53
@leodido
Copy link
Member

leodido commented Mar 17, 2020

/honk

@poiana
Copy link
Contributor

poiana commented Mar 17, 2020

@leodido:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leodido
Copy link
Member

leodido commented Mar 17, 2020

/hold

hold this until 0.21.0 is cut

@krisnova
Copy link
Contributor

/honk
/approve
/lgtm

@poiana
Copy link
Contributor

poiana commented Mar 17, 2020

@kris-nova:
goose image

In response to this:

/honk
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Mar 17, 2020

LGTM label has been added.

Git tree hash: 169e6e276b6efc0f12af311cc8df6c350ca84c09

@krisnova krisnova modified the milestones: 0.22.0, 0.21.0 Mar 17, 2020
@fntlnz
Copy link
Contributor Author

fntlnz commented Mar 17, 2020

/hold cancel

@leodido leodido removed this from the 0.21.0 milestone Mar 18, 2020
@leodido leodido added this to the 0.21.1 milestone Mar 18, 2020
@poiana
Copy link
Contributor

poiana commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kris-nova, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ea46adf into master Mar 18, 2020
@poiana poiana deleted the feat/cri-async-flag branch March 18, 2020 15:23
@nebi-frame
Copy link

Is there any changes on how we are going to build binary and deploy?

@leodido
Copy link
Member

leodido commented Mar 19, 2020

@leodido leodido modified the milestones: 0.21.1, 0.22.0 Mar 23, 2020
@JScrivanich
Copy link

Hey, so after testing this, we are able to confirm that for ECS isntances, this fix has been resolved. However, on our EKS instances, the issue continues to persist. Could you please help us identify why that might be? I confirmed that we installed the latest falco and that it is running with this new flag. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting Null as container name
6 participants