Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(content): update driver load documentation with the new variables #195

Merged
merged 1 commit into from
May 14, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented May 14, 2020

Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com
Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind content

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Refers to #191 - jp and cn translation needs to be done.

Special notes for your reviewer:

Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 60c13c9b2c399bb4723df8d9c03c7633d7cdd41e

1 similar comment
@poiana
Copy link

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 60c13c9b2c399bb4723df8d9c03c7633d7cdd41e

@poiana
Copy link

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f0f8a38 into master May 14, 2020
@poiana poiana deleted the docs/update-driver-load-docs branch May 14, 2020 16:42
poiana pushed a commit that referenced this pull request May 18, 2020
Signed-off-by: TakaoShimizu <takao.shimizu@sysdig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants