Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for Flatcar #131

Merged
merged 7 commits into from
Jun 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
builder/flatcar: Drop requirement to provide '-flatcar' after kernel …
…version

This was an arbitrary requirement that served no purpose. Kernel-crawler
generates configs with the kernelrelease set to the Flatcar version number
without the '-flatcar' suffix, so let's be consistent with that.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
  • Loading branch information
jepio committed Jun 7, 2022
commit 83421f3548b7024df647757fa910c94ea8498e18
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,12 @@ driverversion: master
```

### flatcar

Example configuration file to build both the Kernel module and eBPF probe for Flatcar.
The Flatcar release version needs to be provided in the `kernelrelease` field and must be followed by `-flatcar`.
The Flatcar release version needs to be provided in the `kernelrelease` field instead of the kernel version.

```yaml
kernelrelease: 3185.0.0-flatcar
kernelrelease: 3185.0.0
target: flatcar
output:
module: /tmp/falco-flatcar-3185.0.0.ko
Expand Down
2 changes: 1 addition & 1 deletion pkg/driverbuilder/builder/flatcar.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (c flatcar) Script(cfg Config) (string, error) {
}

kr := kernelrelease.FromString(cfg.Build.KernelRelease)
if kr.Extraversion != "flatcar" {
if kr.Extraversion != "" {
return "", fmt.Errorf("unexpected extraversion: %s", kr.Extraversion)
}

Expand Down