Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driverbuilder for Rocky Linux #130

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Add driverbuilder for Rocky Linux #130

merged 2 commits into from
Apr 15, 2022

Conversation

dwindsor
Copy link
Contributor

@dwindsor dwindsor commented Mar 24, 2022

Signed-off-by: David Windsor dwindsor@secureworks.com

./_output/bin/driverkit -l debug docker --output-module \ /tmp/falco_rocky.ko --kernelversion=1
--kernelrelease=4.18.0-348.el8.0.2.x86_64 --driverversion=b7eb0dd65226a8dc254d228c8d950d07bf3521d2
--moduledrivername="falco_rocky" --moduledevicename="falco-rocky" --target=rocky

DEBU Ifilename:       /tmp/driver/module.ko 
DEBU schema_version: 1.0.0                        
DEBU api_version:    1.0.0                        
DEBU build_commit:   b7eb0dd65226a8dc254d228c8d950d07bf3521d2 
DEBU version:        b7eb0dd65226a8dc254d228c8d950d07bf3521d2 
DEBU author:         the Falco authors            
DEBU license:        GPL                          
DEBU rhelversion:    8.5                          
DEBU srcversion:     FB3CE3C01854B85C4CCF472      
DEBU depends:                                     
DEBU name:           falco_rocky                  
DEBU vermagic:       4.18.0-348.el8.0.2.x86_64 SMP mod_unload modversions  
DEBU parm:           max_consumers:Maximum number of consumers that can simultaneously open the devices (uint) 
DEBU parm:           verbose:Enable verbose logging (bool) 

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test
/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:
/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:

CentOS was EOL'ed in December, 2021. Rocky Linux is the successor to CentOS. Add support to driverkit for building Rocky Linux kernel drivers.

Which issue(s) this PR fixes:

Fixes #129

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new: support for Rocky Linux

Signed-off-by: David Windsor <dwindsor@secureworks.com>
@poiana poiana added kind/feature New feature or request dco-signoff: yes area/build Further information is requested labels Mar 24, 2022
@poiana poiana requested review from fntlnz and leodido March 24, 2022 20:04
@poiana poiana added the size/L label Mar 24, 2022
Signed-off-by: David Windsor <dwindsor@secureworks.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Apr 6, 2022

LGTM label has been added.

Git tree hash: 4a396611f19f95aef76dcd111c70d22b38506799

@poiana
Copy link

poiana commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwindsor, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 6, 2022
@dwindsor
Copy link
Contributor Author

/close

@poiana poiana closed this Apr 15, 2022
@poiana
Copy link

poiana commented Apr 15, 2022

@dwindsor: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwindsor
Copy link
Contributor Author

/reopen

@poiana
Copy link

poiana commented Apr 15, 2022

@dwindsor: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Apr 15, 2022
@poiana poiana merged commit 55e4c1e into falcosecurity:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build Further information is requested dco-signoff: yes kind/feature New feature or request lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Rocky Linux
3 participants