Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(builder): pin base image version to debian:buster #110

Closed
wants to merge 1 commit into from

Conversation

leogr
Copy link
Member

@leogr leogr commented Nov 19, 2021

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Currently, the publishing of the builder image is broken (see the failing test on the master branch).

So, this PR introduces a simple workaround to make the builder image work again.
The root issue is due to debian:stable which recently moved forward and removed clang7. So we just pin the last working version, which is debian:buster. We already did the same thing on Falco, see falcosecurity/falco#1719.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Upgrading to a newer clang version is out-of-scope for this PR. The intent is just to make the tool work again shortly.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr requested review from leodido and fntlnz November 19, 2021 11:06
@poiana poiana added kind/bug Something isn't working dco-signoff: yes area/build Further information is requested labels Nov 19, 2021
@poiana
Copy link

poiana commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leogr
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/XS label Nov 19, 2021
@leogr
Copy link
Member Author

leogr commented Nov 22, 2021

Sorry, I did not realize this is a dup of #109 :/

So,
/close

@poiana
Copy link

poiana commented Nov 22, 2021

@leogr: Closed this PR.

In response to this:

Sorry, I did not realize this is a dup of #109 :/

So,
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Further information is requested dco-signoff: yes kind/bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants