Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bidirectional gRPC outputs - client update #45

Merged
merged 17 commits into from
Jun 30, 2020
Merged

bidirectional gRPC outputs - client update #45

merged 17 commits into from
Jun 30, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 1, 2020 •
edited by leodido
Loading

Co-Authored-By: Leonardo Di Donato leodidonato@gmail.com
Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area client
/area examples

What this PR does / why we need it:

Update this client to reflect the changes going into the server at via falcosecurity/falco#1241 -

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

BREAKING CHANGE: the output service named `output.subscribe` is now split into two different methods, the service name is now `outputs`.
BREAKING CHANGE: `outputs.get`: open a connection and send a request, receive all the available events until now, and stop.
BREAKING CHANGE: `outputs.sub`: open a connection to stream many requests, for each one of them it streams back all the available events and keeps the stream and connection open.

@fntlnz @leodido
update: initial support for bidirectional sub
72ec464 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Contributor Author

fntlnz commented Jun 1, 2020

Keeping the wip since there are still some changes we need to make and tests against the new server.

@poiana poiana requested review from leodido and mfdii June 1, 2020 11:11
leodido and others added 4 commits June 1, 2020 14:32
@leodido
build: mocks macro
b874754 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(pkg/api): outputs API
d09c2e3 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(pkg/client): client to use new outputs gRPC API interface
9e4c866 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(examples): examples to use the new outputs API
6a937e8 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido force-pushed the feat/bidi-grpc-outputs branch from 6e7b18c to 6a937e8 Compare June 1, 2020 14:35
@fntlnz @leodido
update(examples/output): update examples to reflect the new output
6d07e8d 
service

Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana poiana added size/XL and removed size/L labels Jun 1, 2020
fntlnz and others added 4 commits June 1, 2020 16:56
@fntlnz @leodido
build: install mockgen
4c70ff1 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
update(examples): update to use outputs instead of output
abf55d2 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
docs: update readme to include the new examples
217fbfd 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz @leodido
build: retrieve protos before doing tests
a51eea7 
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
leodido
leodido previously approved these changes Jun 1, 2020
View reviewed changes
@fntlnz fntlnz mentioned this pull request Jun 8, 2020
Closed
@leogr @fntlnz
new(pkg/client): OutputsWatch function (package level)
3b6f8eb 
`client.OutputsWatch` is a package level func, similar to `(*Client).OutputsWatch()`, but requires an `outputs.Service_SubClient` to be passed as argument.

Co-Authored-By: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed stale reviews from leodido and themself via 3b6f8eb June 9, 2020 15:35
leodido
leodido previously approved these changes Jun 9, 2020
View reviewed changes
@poiana poiana added the lgtm label Jun 9, 2020
@poiana
Copy link

poiana commented Jun 9, 2020

LGTM label has been added.

Git tree hash: 8db15a22efeb01a34018d208a368206d8a37cdec

@poiana poiana added the approved label Jun 9, 2020
leogr
leogr previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leogr leogr mentioned this pull request Jun 10, 2020
Merged
3 tasks
@leodido @fntlnz
build: refer to protos on Falco master
c052cbe 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido dismissed stale reviews from leogr and themself via c052cbe June 30, 2020 09:28
@leodido @fntlnz
update(pkg/api/**/mocks): API mocks (for testing) should be checked in
7287714 
Fixes #46

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
leodido approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@poiana poiana added the lgtm label Jun 30, 2020
@poiana
Copy link

poiana commented Jun 30, 2020

LGTM label has been added.

Git tree hash: 4a8ed244304278cd1b4c329995fbc98d8c3589eb

@poiana
Copy link

poiana commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Jun 30, 2020

/hold cancel

@leodido leodido removed the request for review from mfdii June 30, 2020 09:38
@poiana poiana merged commit 71d080b into master Jun 30, 2020
@poiana poiana deleted the feat/bidi-grpc-outputs branch June 30, 2020 09:40
@leogr leogr added this to the v0.2.0 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido approved these changes

@bgarber bgarber bgarber left review comments

@leogr leogr leogr left review comments

Assignees

@leodido leodido

@leogr leogr

Labels
approved area/client area/examples dco-signoff: yes kind/feature New feature or request lgtm release-note size/XXL
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fntlnz @poiana @leodido @bgarber @leogr