refactor: move Faker::BossaNova under Faker::Music::BossaNova
#3140
+79
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thdaraujo
force-pushed
the
ta/move-bossa-nova-generator
branch
from
22c96f2 to
851b5dc
Compare
thdaraujo
changed the title
Faker::BossaNova to Faker::Music::BossaNovaFaker::BossaNova under Faker::Music::BossaNova
thdaraujo
force-pushed
the
ta/move-bossa-nova-generator
branch
from
851b5dc to
ceea16e
Compare
(fixes #3139) Moves +Faker::BossaNova+ generator under +Faker::Music::BossaNova+
thdaraujo
force-pushed
the
ta/move-bossa-nova-generator
branch
from
ceea16e to
b18a9d2
Compare
stefannibrasil
approved these changes
Nov 16, 2025
| - [Faker::Music::Rush](doc/music/rush.md) | ||
| - [Faker::Music::SmashingPumpkins](doc/music/smashing_pumpkins.md) | ||
| - [Faker::Music::UmphreysMcgee](doc/music/umphreys_mcgee.md) | ||
| - [Faker::Music::BossaNova](doc/music/bossa_nova.md) |
stefannibrasil
pushed a commit
that referenced
this pull request
Jan 8, 2026
) (fixes #3139) Moves +Faker::BossaNova+ generator under +Faker::Music::BossaNova+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #3139)
Moves
Faker::BossaNovagenerator underFaker::Music::BossaNovaMotivation / Background
Moving this generator under music will make it more discoverable. We've been reorganizing generators to make things more tidy.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]