Skip to content

Conversation

@SleekMutt
Copy link
Contributor

@SleekMutt SleekMutt commented Nov 4, 2025

Motivation / Background

This PR fixes minor typos, and removes a duplicate entry of Tsun first name. Also, it removes DG and DR marks, which indicate that the weapon is from specific DLC, that is redundant in the context of that generator, as items should be named as they are without any technical additions.

Additional information

Correct names for fixed typos can be found here.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@thdaraujo thdaraujo changed the title Updated locales and fixed typos in elder_scrolls.yml Improvements and fixes for Elder Scrolls locale (elder_scrolls.yml) Nov 16, 2025
@thdaraujo thdaraujo merged commit fced57b into faker-ruby:main Nov 16, 2025
8 checks passed
@SleekMutt SleekMutt deleted the fixed-elder-scrolls-en branch November 18, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants