Skip to content

Conversation

@bensheldon
Copy link
Contributor

Motivation / Background

Fixes an unclosed quote in a YAML file. Not closing the quote in YAML results in the quote being present in the resulting string. Here is the result of this fix:

-Bronze'
+Bronze

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests and Rubocop are passing before submitting your proposed changes.

@thdaraujo
Copy link
Contributor

nice catch, do you mind reformatting the locale too? Thanks!

When in doubt, run `bundle exec rake reformat_yaml['lib/path/to/file.yml']` to reformat your YAML file.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@thdaraujo thdaraujo changed the title Fix unclosed quote in cosmere.yml Fix unclosed quote in cosmere.yml May 4, 2025
@thdaraujo thdaraujo changed the title Fix unclosed quote in cosmere.yml Fix unclosed quote in locales/en/cosmere.yml May 4, 2025
@thdaraujo thdaraujo merged commit d7103c7 into faker-ruby:main May 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants