Bump rubocop-minitest and fix rubocop's offense #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting this Rubocop's offense:
```
lib/helpers/deprecator.rb:106:7: C: Minitest/SkipWithoutReason: Add a reason explaining why the test is skipped.
skip == true
^^^^
```
That's because we needed to use the @Skip instance instead.
stefannibrasil
force-pushed
the
sb-bump-rubocop-minitest
branch
from
7d2cfa0 to
73ea7b2
Compare
thdaraujo
pushed a commit
that referenced
this pull request
Mar 11, 2025
Bump rubocop-minitest and fix rubocop's offense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting this Rubocop's offense:
That's because we needed to use the @Skip instance instead.