Skip to content

Conversation

@brupla6126
Copy link
Contributor

Motivation / Background

Our Rails app test suite validations are frequently failing when using :fr locale due to
1 - Numbers in city names
2 - Extra space in street names

Faker::Address.city

  • Dumbéa11
  • Dunkerque14

Faker::Address.street_address

  • Leo Bleriot with 2 spaces

@stefannibrasil
Copy link
Contributor

hi @brupla6126 do you mind running this formatter first? https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files without this format, it's really hard to review this. This is one of the files that are missing this reformat. Thank you!

@brupla6126 brupla6126 force-pushed the fix_fr_address_city_and_street_translations branch from b651d6c to 55fad8c Compare November 7, 2024 12:02
@brupla6126
Copy link
Contributor Author

brupla6126 commented Nov 7, 2024

hi @brupla6126 do you mind running this formatter first? https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files without this format, it's really hard to review this. This is one of the files that are missing this reformat. Thank you!

Hey @stefannibrasil I formatted the file but I noticed that many other locale files are unformatted. Maybe a rake task that will format all locale files at once?

@simplexbruno
Copy link

@stefannibrasil Is this gem still maintained ? Many PRs waiting in line... Maybe add more maintainers ?

@thdaraujo thdaraujo changed the title Correct Faker::Address.city and Faker::Address.street_address data for :fr locale Correct Faker::Address.city and Faker::Address.street_address for :fr locale Jan 7, 2025
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thdaraujo thdaraujo merged commit 13203f1 into faker-ruby:main Jan 7, 2025
@stefannibrasil
Copy link
Contributor

Thank you @thdaraujo. I am back from a long vacation. Thanks!

@brupla6126 brupla6126 deleted the fix_fr_address_city_and_street_translations branch January 7, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants