fix(location): update valid ZIP ranges for FL and VA #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewmayer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3167 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2798 2798
Lines 227793 227793
Branches 959 957 -2
=======================================
+ Hits 227726 227732 +6
+ Misses 67 61 -6
|
matthewmayer
added
c: bug
Shinigami92
approved these changes
Oct 10, 2024
ST-DDT
approved these changes
Oct 10, 2024
|
FL and VA don't throw any errors anymore, but what about these: Mismatch detected: Generated 72643 for AR but located in MO
Mismatch detected: Generated 83414 for ID but located in WY
Mismatch detected: Generated 96799 for HI but located in AS |
ST-DDT
changed the title
see #3169 these seem to be various one-off weirdnesses, can probably address later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3165
Changes the VA zips to 22201-24599 (this is not every VA code, but shouldnt overlap with DC)
Changes the FL zips to
"320","321","322","323","324","325","326","327","328","329","330","331","332","333","334","335","336","337","338","339","341","342","344","346","347","349"plus a 2 digit endingNot very elegant, but this ensures we don't generate 340... military ZIPs.
ref https://en.wikipedia.org/wiki/List_of_ZIP_Code_prefixes