Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify the generated image links are working #3127

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 21, 2024

Fixes #3112

This PR adds a test to the image module/all methods that return a url that actually points to something to ensure the url is working as expected.

Thoughts and Considerations

The current setup only runs these tests in CI to avoid running into "this service might be tracking you" issues when running the tests locally.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: image Something is referring to the image module labels Sep 21, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 21, 2024
@ST-DDT ST-DDT self-assigned this Sep 21, 2024
Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 972de1b
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670b01152b68d5000830c2aa
😎 Deploy Preview https://deploy-preview-3127.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (34cf364) to head (972de1b).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3127    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2798     2798            
  Lines      227806   227806            
  Branches      576      959   +383     
========================================
  Hits       227732   227732            
  Misses         74       74            

see 2 files with indirect coverage changes

@Shinigami92
Copy link
Member

The current provided solution feels like mixin unit with integration tests. IMO we should split them from each other. That way, because we rely here also on external sources, we could execute this in a scheduled workflow e.g. every week or so, so we also reduce the "ddos" outgoing from this repo.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: image Something is referring to the image module p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to methods that produce links to ensure they still work
3 participants