-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: verify the generated image links are working #3127
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3127 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2798 2798
Lines 227806 227806
Branches 576 959 +383
========================================
Hits 227732 227732
Misses 74 74 |
The current provided solution feels like mixin unit with integration tests. IMO we should split them from each other. That way, because we rely here also on external sources, we could execute this in a scheduled workflow e.g. every week or so, so we also reduce the "ddos" outgoing from this repo. |
Fixes #3112
This PR adds a test to the image module/all methods that return a url that actually points to something to ensure the url is working as expected.
Thoughts and Considerations
The current setup only runs these tests in CI to avoid running into "this service might be tracking you" issues when running the tests locally.