Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove potential future feature todos #2959

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 20, 2024

This PR removes some potential future feature TODO comments.
These are better suited as issues instead of inlien comments.

One of the TODOs has an issue already:

The other twos are features, that haven't been asked in the meantime.
If the need arises, we can create an issue and track the actual requirements


This is an attempt to solve the remaining TODOs-

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Jun 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 20, 2024
@ST-DDT ST-DDT requested review from a team June 20, 2024 12:40
@ST-DDT ST-DDT self-assigned this Jun 20, 2024
@ST-DDT ST-DDT changed the title chore: remove future feature todos chore: remove potential future feature todos Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9e9d83f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66754cd6e7e23a000873fa75
😎 Deploy Preview https://deploy-preview-2959.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d31c635) to head (9e9d83f).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2959      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2989     2989              
  Lines      216085   216081       -4     
  Branches      950      595     -355     
==========================================
- Hits       216010   215994      -16     
- Misses         75       87      +12     
Files Coverage Δ
src/modules/helpers/index.ts 98.36% <ø> (-0.01%) ⬇️
src/modules/location/index.ts 100.00% <ø> (ø)
src/modules/system/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from Shinigami92 June 20, 2024 14:03
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind 😺

@ST-DDT ST-DDT merged commit ff2dae4 into next Jun 21, 2024
23 checks passed
@ST-DDT ST-DDT deleted the chore/remove-TODOs branch June 21, 2024 10:14
eLoyyyyy pushed a commit to eLoyyyyy/faker that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants