Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove arrayElement(s) js only error #2958

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 20, 2024

This is an attempt to fix all remaining TODOs.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Jun 20, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Jun 20, 2024
@ST-DDT ST-DDT requested review from a team June 20, 2024 11:14
@ST-DDT ST-DDT self-assigned this Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f6621ab
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66754c164fdaf50008894d68
😎 Deploy Preview https://deploy-preview-2958.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@d6924f7). Learn more about missing BASE report.

Current head 8444739 differs from pull request most recent head f6621ab

Please upload reports for the commit f6621ab to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2958   +/-   ##
=======================================
  Coverage        ?   99.96%           
=======================================
  Files           ?     2987           
  Lines           ?   216038           
  Branches        ?      950           
=======================================
  Hits            ?   215967           
  Misses          ?       71           
  Partials        ?        0           
Files Coverage Δ
src/modules/helpers/index.ts 98.36% <ø> (ø)

Shinigami92
Shinigami92 previously approved these changes Jun 20, 2024
@ST-DDT ST-DDT requested a review from a team June 20, 2024 12:31
@matthewmayer
Copy link
Contributor

Does this merit a mention in the migration guide?

@ST-DDT
Copy link
Member Author

ST-DDT commented Jun 20, 2024

Does this merit a mention in the migration guide?

IMO not, but we have a similar section for a9dc701

Should I mark this as breaking as well?

docs/guide/upgrading.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT enabled auto-merge (squash) June 21, 2024 09:42
@ST-DDT ST-DDT merged commit d31c635 into next Jun 21, 2024
21 checks passed
@ST-DDT ST-DDT deleted the chore/helpers/js-legacy branch June 21, 2024 09:49
eLoyyyyy pushed a commit to eLoyyyyy/faker that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants