-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(docs): fix test timeout #2782
Conversation
✅ Deploy Preview for fakerjs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2782 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2973 2973
Lines 212613 212613
Branches 601 950 +349
==========================================
- Hits 212540 212529 -11
- Misses 73 84 +11 |
Not sure if pumping up the timeout isn't only kicking the porplem down the road. |
This is exactly the reason why I didn't approved this PR yet |
I simply wanted to leave the comment to explain why I feel unsure about approving this (same as @Shinigami92 stated). That being said, I currently don't feel motivated to inspect this issue myself. |
Well, not doing anything to prevent the errors is also just "kicking the problem down the road" with extra work |
Collecting some of the failing CIs
Right now it is 100% inside |
|
It looks like the problem always and only appears in I suggest to investigate why it is failing there, are there specific load-times? Can we e.g. cache something for a run? Or specifically the other way: do we need to warmup something? |
The first dynamic |
This is an attempt to fix the frequent test timeouts in verify-jsdoc-tags.
I was unable to identify the root cause of this beyond:
Some strange things I noticed:
pnpm run test
, re-running the tests (without restarting node) doesn't repeat the errorimport(path)
but not sure