-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(node): update nvmrc #2735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2735 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2859 2859
Lines 248602 248602
Branches 987 627 -360
==========================================
- Hits 247556 247545 -11
- Misses 1017 1028 +11
Partials 29 29 |
Is this file still relevant? We introduced a dev containers environment in #1652, which allows developers to streamline the setup of the projects environment. |
Dev containers cause some issues for me when I try to commit due to win vs linux paths. |
Lets merge it for now and talk in the teammeeting which dev environment/tooling we want to support. |
Update to
iron
(Node 20).Alternatively we could switch to
hydrogen
(Node 18).(or should we remove that file?)