Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(color): use signature level defaults #2703

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 2, 2024

Fixes #2432

Old

grafik

New

grafik

These were all cases that I know of, if we find others later, we can create a new PR for them then.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: color Something is referring to the color module labels Mar 2, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 2, 2024
@ST-DDT ST-DDT requested review from a team March 2, 2024 13:31
@ST-DDT ST-DDT self-assigned this Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (2b15f2e) to head (1a3acf6).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2703      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2846     2846              
  Lines      248717   248717              
  Branches     1015     1007       -8     
==========================================
- Hits       247659   247655       -4     
+ Misses       1058     1033      -25     
- Partials        0       29      +29     
Files Coverage Δ
src/modules/color/index.ts 100.00% <100.00%> (+0.20%) ⬆️

... and 31 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) March 4, 2024 00:17
@ST-DDT ST-DDT merged commit 82cdf0f into next Mar 4, 2024
16 checks passed
@ST-DDT ST-DDT deleted the refactor/color/signature-level-defaults branch March 4, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default value isn't always shown in the jsdocs
3 participants