-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(datatype)!: remove v8 deprecated datatype methods #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Nothing urgent
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: datatype
Something is referring to the datatype module
labels
Feb 26, 2024
Shinigami92
commented
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2694 +/- ##
========================================
Coverage 99.57% 99.57%
========================================
Files 2815 2815
Lines 250304 249845 -459
Branches 1084 1065 -19
========================================
- Hits 249239 248790 -449
- Misses 1036 1055 +19
+ Partials 29 0 -29
|
ST-DDT
previously approved these changes
Feb 26, 2024
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
approved these changes
Feb 26, 2024
matthewmayer
approved these changes
Feb 27, 2024
xDivisionByZerox
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: datatype
Something is referring to the datatype module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove v8 deprecated datatype methods