Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): replace vitest v1 deprecations #2590

Merged
merged 5 commits into from
Feb 9, 2024
Merged

chore(deps): replace vitest v1 deprecations #2590

merged 5 commits into from
Feb 9, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Dec 28, 2023 •
edited
Loading

manually crafted PR

closes #2573

not working right now, due to Node v14...

@Shinigami92 Shinigami92 added the c: dependencies Pull requests that adds/updates a dependency label Dec 28, 2023
@Shinigami92 Shinigami92 self-assigned this Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9257f58) 99.57% compared to head (6518f6a) 99.56%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2590      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250525   250525              
  Branches     1151      740     -411     
==========================================
- Hits       249454   249439      -15     
- Misses       1071     1086      +15

see 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Dec 28, 2023
xDivisionByZerox
xDivisionByZerox previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit lost as I didn't see the guide on their website or in the release. I'll leave the Vitest migration guide here just in case another reviewer has the same problem as I did.

ST-DDT
ST-DDT previously approved these changes Dec 28, 2023
View reviewed changes
@ST-DDT ST-DDT modified the milestones: vAnytime, v9.0 Dec 28, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent do NOT merge yet Do not merge this PR into the target branch yet labels Dec 28, 2023
@matthewmayer
Copy link
Contributor

Will Faker v9 drop node v14 and v16?

Because the vitest migration guide says it requires v18+

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Dec 28, 2023 •
edited
Loading

Will Faker v9 drop node v14 and v16?

Because the vitest migration guide says it requires v18+

Yes. #2121 is targeted for milestone v9.

Oh sorry, I did not see the "AND v16". We will only drop v14 as far as I can tell.

But v16 did reach End-of-Life as well.

@ST-DDT
Copy link
Member

ST-DDT commented Dec 28, 2023 •
edited
Loading

IMO we will/should drop v16 support as well.

@Shinigami92
Copy link
Member Author

Yes, v16 is already legacy and not supported by Node anymore

ST-DDT
ST-DDT previously approved these changes Jan 1, 2024
View reviewed changes
@ST-DDT ST-DDT removed the do NOT merge yet Do not merge this PR into the target branch yet label Feb 8, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Feb 8, 2024

@Shinigami92 Could you please fix the merge conflicts here?

@ST-DDT
Copy link
Member

ST-DDT commented Feb 9, 2024

I fixed the merge conflicts for you. (Totally forgot about this one)

@ST-DDT ST-DDT marked this pull request as ready for review February 9, 2024 14:42
@ST-DDT ST-DDT requested review from a team February 9, 2024 14:42
@ST-DDT ST-DDT changed the title chore(deps): update vitest to v1 (major) chore(deps): replace vitest v1 deprecations Feb 9, 2024
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 9, 2024 16:28
@Shinigami92 Shinigami92 merged commit aa183ad into next Feb 9, 2024
16 checks passed
@Shinigami92 Shinigami92 deleted the major-vitest-v1 branch February 9, 2024 16:41
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @xDivisionByZerox @ST-DDT