Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(finance): simplify litecoin address implementation #2495

Merged
merged 3 commits into from
Oct 23, 2023
Merged

refactor(finance): simplify litecoin address implementation #2495

merged 3 commits into from
Oct 23, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 22, 2023

Simplifies the faker.finance.litecoinAddress implementation by replacing faker.helpers.arrayElement with faker.string.fromCharacters.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module labels Oct 22, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 22, 2023
@ST-DDT ST-DDT requested review from a team October 22, 2023 14:18
@ST-DDT ST-DDT self-assigned this Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Merging #2495 (d30efd1) into next (bd19703) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2495   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255520   255520           
  Branches     1100     1104    +4     
=======================================
+ Hits       254456   254474   +18     
+ Misses       1036     1018   -18     
  Partials       28       28
Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 23, 2023 08:47
@xDivisionByZerox xDivisionByZerox merged commit e901641 into next Oct 23, 2023
20 checks passed
@ST-DDT ST-DDT deleted the refactor/finance/litecoin-address branch November 9, 2023 22:12
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @matthewmayer @import-brain @xDivisionByZerox