Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(number): improve documentation regarding number bounds #2474

Merged
merged 2 commits into from
Oct 14, 2023
Merged

docs(number): improve documentation regarding number bounds #2474

merged 2 commits into from
Oct 14, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 12, 2023

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: number Something is referring to the number module labels Oct 12, 2023
@ST-DDT ST-DDT added this to the v8.x milestone Oct 12, 2023
@ST-DDT ST-DDT requested review from a team October 12, 2023 20:45
@ST-DDT ST-DDT self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #2474 (16d96a9) into next (e946e6a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2474      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255516   255524       +8     
  Branches     1105     1104       -1     
==========================================
- Hits       254479   254473       -6     
- Misses       1009     1023      +14     
  Partials       28       28
Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) October 14, 2023 09:08
@ST-DDT ST-DDT merged commit b4fe307 into next Oct 14, 2023
20 checks passed
@ST-DDT ST-DDT deleted the docs/number/bounds branch October 14, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation m: number Something is referring to the number module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

number.float is unable to return 1/max exactly
3 participants
@ST-DDT @matthewmayer @xDivisionByZerox