-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
c: bugSomething isn't workingSomething isn't workingc: localePermutes locale definitionsPermutes locale definitionss: acceptedAccepted feature / Confirmed bugAccepted feature / Confirmed bug
Description
Pre-Checks
- Follow our Code of Conduct.
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Faker issue and not related to a combination with another package.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
- I am willing to provide a PR.
Describe the bug
Sometimes when doing fakerHE.lorem.words(x) one of the words is empty string
Probablt stems from https://github.com/faker-js/faker/blob/next/src/locales/he/lorem/word.ts having empty string in line 103
Minimal reproduction code
No response
Additional Context
No response
Environment Info
System:
OS: Windows 11 10.0.26100
CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
Memory: 8.23 GB / 31.65 GB
Binaries:
Node: 20.15.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - C:\Users\erezc\AppData\Roaming\npm\yarn.CMD
npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: 143.0.7499.193
Edge: Chromium (140.0.3485.54)
Internet Explorer: 11.0.26100.7309Which module system do you use?
- CJS
- ESM
Used Package Manager
npm
Metadata
Metadata
Assignees
Labels
c: bugSomething isn't workingSomething isn't workingc: localePermutes locale definitionsPermutes locale definitionss: acceptedAccepted feature / Confirmed bugAccepted feature / Confirmed bug