chore: fix lint errors

faker-js · Aug 30, 2024 · ca7657c · ca7657c
1 parent 97c84fd
commit ca7657c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 14 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -27,6 +27,7 @@ export default tseslint.config(
       'docs/.vitepress/components/shims.d.ts',
       'docs/.vitepress/shared/utils/slugify.ts',
       'docs/.vitepress/theme/index.ts',
+      'eslint.config.js',
     ],
   },
   {
@@ -57,7 +58,6 @@ export default tseslint.config(
       '@typescript-eslint': tseslint.plugin,
     },
     languageOptions: {
-      parser: tseslint.parser,
       parserOptions: {
         project: true,
         warnOnUnsupportedTypeScriptVersion: false,
@@ -148,21 +148,13 @@ export default tseslint.config(
         // @ts-expect-error: Just eat it!
         fixupPluginRules(eslintPluginDeprecation),
     },
-    languageOptions: {
-      parser: tseslint.parser,
-      parserOptions: {
-        project: true,
-        warnOnUnsupportedTypeScriptVersion: false,
-      },
-    },
     rules: {
       'deprecation/deprecation': 'error',
     },
   },
   //#endregion
 
   //#region unicorn
-  // @ts-expect-error: Ignore for now
   eslintPluginUnicorn.configs['flat/recommended'],
   {
     rules: {

diff --git a/test/locale-imports.spec.ts b/test/locale-imports.spec.ts
@@ -5,7 +5,7 @@ import { keys } from '../src/internal/keys';
 
 describe.each(keys(allLocales))('locale imports', (locale) => {
   it(`should be possible to directly require('@faker-js/faker/locale/${locale}')`, () => {
-    // eslint-disable-next-line @typescript-eslint/no-var-requires, unicorn/prefer-module
+    // eslint-disable-next-line @typescript-eslint/no-require-imports, unicorn/prefer-module
     const { faker } = require(`../dist/locale/${locale}.cjs`) as {
       faker: Faker;
     };

diff --git a/test/simple-faker.spec.ts b/test/simple-faker.spec.ts
@@ -9,10 +9,10 @@ describe('simpleFaker', () => {
       .filter((key) => typeof console[key] === 'function')
       .map((methodName) => vi.spyOn(console, methodName));
 
-    // eslint-disable-next-line @typescript-eslint/no-var-requires, unicorn/prefer-module -- Using import() requires types being build but the CI / TS-Check runs without them.
-    require('..').simpleFaker;
+    // eslint-disable-next-line @typescript-eslint/no-require-imports, unicorn/prefer-module -- Using import() requires types being build but the CI / TS-Check runs without them.
+    expect(require('..').simpleFaker).toBeDefined();
 
-    new SimpleFaker();
+    expect(new SimpleFaker()).toBeDefined();
 
     for (const spy of spies) {
       expect(spy).not.toHaveBeenCalled();

diff --git a/test/support/seeded-runs.ts b/test/support/seeded-runs.ts
@@ -165,7 +165,7 @@ class TestGenerator<
    *
    * @param method The name of the method.
    */
-  it<TMethodName extends NoArgsMethodOf<TModule>>(method: TMethodName): this {
+  it(method: NoArgsMethodOf<TModule>): this {
     return this.itRepeated(method, 1);
   }
 
@@ -176,6 +176,8 @@ class TestGenerator<
    * @param method The name of the method.
    * @param repetitions The number of repetitions to run.
    */
+  // TODO @ST-DDT 2024-08-19: https://github.com/typescript-eslint/typescript-eslint/issues/9828
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
   itRepeated<TMethodName extends NoArgsMethodOf<TModule>>(
     method: TMethodName,
     repetitions: number

diff --git a/test/vitest-extensions.ts b/test/vitest-extensions.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import { expect } from 'vitest';
 
 expect.extend({