New robot controls #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum class VisionModes { BALL, HIGHGOAL } | ||
|
|
||
| class VisionToggleSubsystem() : SubsystemBase() { | ||
| var visionMode = VisionModes.BALL |
There was a problem hiding this comment.
I'm not sure it makes sense to make the vision mode (ball/high goal) a toggle. The driver has to remember which mode the robot is in, may have to switch frequently, and could get bad results if they choose the wrong mode.
It probably makes more sense to just assign high goal vision and ball vision to separate buttons. You could move climbing to the D-Pad, use the triggers for vision (ie - right high goal, left ball), and keep shooting on the right bumper (or something like that)
There was a problem hiding this comment.
Ok. I've sent you my thoughts on discord and may update the controls again before Thursday
edwardwawrzynek
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.