🐛 Destination S3 Glue: Fix decimal type syntax (airbytehq#25813)

* destination-s3-glue: Fix decimal type syntax The definition of the decimal type as `decimal(38,38)` was incorrect as it caused the query engine to interpret that as meaning that all 38 digits had to be to the right of the decimal place, so any whole number values would overflow. Setting it as `decimal(38)` allows for the full 38 digits, but with flexible scale. * auto-bump connector version --------- Co-authored-by: Tobias Macey <tmacey@mit.edu> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
fairhopeweb · May 4, 2023 · 8e18484 · 8e18484
1 parent 5f7248c
commit 8e18484
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/destination_definitions.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/destination_definitions.yaml
@@ -356,7 +356,7 @@
 - name: S3 Glue
   destinationDefinitionId: 471e5cab-8ed1-49f3-ba11-79c687784737
   dockerRepository: airbyte/destination-s3-glue
-  dockerImageTag: 0.1.6
+  dockerImageTag: 0.1.7
   documentationUrl: https://docs.airbyte.com/integrations/destinations/s3-glue
   icon: s3-glue.svg
   releaseStage: alpha

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/destination_specs.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/destination_specs.yaml
@@ -6309,7 +6309,7 @@
     supported_destination_sync_modes:
     - "overwrite"
     - "append"
-- dockerImage: "airbyte/destination-s3-glue:0.1.6"
+- dockerImage: "airbyte/destination-s3-glue:0.1.7"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/destinations/s3-glue"
     connectionSpecification:

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json b/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json
@@ -6102,7 +6102,7 @@
     "destinationDefinitionId": "471e5cab-8ed1-49f3-ba11-79c687784737",
     "name": "S3 Glue",
     "dockerRepository": "airbyte/destination-s3-glue",
-    "dockerImageTag": "0.1.6",
+    "dockerImageTag": "0.1.7",
     "documentationUrl": "https://docs.airbyte.com/integrations/destinations/s3-glue",
     "icon": "s3-glue.svg",
     "spec": {

diff --git a/airbyte-integrations/connectors/destination-s3-glue/Dockerfile b/airbyte-integrations/connectors/destination-s3-glue/Dockerfile
@@ -14,5 +14,5 @@ ENV APPLICATION destination-s3-glue
 
 COPY --from=build /airbyte /airbyte
 
-LABEL io.airbyte.version=0.1.6
+LABEL io.airbyte.version=0.1.7
 LABEL io.airbyte.name=airbyte/destination-s3-glue
diff --git a/...ion-s3-glue/src/main/java/io/airbyte/integrations/destination/s3_glue/GlueOperations.java b/...ion-s3-glue/src/main/java/io/airbyte/integrations/destination/s3_glue/GlueOperations.java
@@ -130,8 +130,8 @@ private String transformSchemaRecursive(JsonNode jsonNode) {
           yield "int";
         }
         // Default to use decimal as it is a more precise type and allows for large values
-        // Set the default scale and precision to 38 to allow or the widest range of values
-        yield "decimal(38,38)";
+        // Set the default scale 38 to allow for the widest range of values
+        yield "decimal(38)";
       }
       case "boolean" -> "boolean";
       case "integer" -> "int";

diff --git a/docs/integrations/destinations/s3-glue.md b/docs/integrations/destinations/s3-glue.md
@@ -245,7 +245,8 @@ Output files can be compressed. The default option is GZIP compression. If compr
 
 | Version | Date       | Pull Request                                             | Subject                                                                                 |
 |:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------|
-| 0.1.6   | 2023-04-13 | [25178](https://github.com/airbytehq/airbyte/pull/25178) | Fix decimal precision and scale to allow for a wider range of numeric values         |
+| 0.1.7   | 2023-05-01 | [25724](https://github.com/airbytehq/airbyte/pull/25724) | Fix decimal type creation syntax to avoid overflow                                      |
+| 0.1.6   | 2023-04-13 | [25178](https://github.com/airbytehq/airbyte/pull/25178) | Fix decimal precision and scale to allow for a wider range of numeric values            |
 | 0.1.5   | 2023-04-11 | [25048](https://github.com/airbytehq/airbyte/pull/25048) | Fix config schema to support new JSONL flattening configuration interface               |
 | 0.1.4   | 2023-03-10 | [23950](https://github.com/airbytehq/airbyte/pull/23950) | Fix schema syntax error for struct fields and handle missing `items` in array fields    |
 | 0.1.3   | 2023-02-10 | [22822](https://github.com/airbytehq/airbyte/pull/22822) | Fix data type for _ab_emitted_at column in table definition                             |