-
Notifications
You must be signed in to change notification settings - Fork 1
Rework on updating the homepage #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideReworks the marketing and navigation aspects of the DMP Chef homepage and app to position it as an open-source pipeline with a testing interface, adds team and funding sections, updates navigation labels and GitHub entry points, and introduces logo assets used across the new layout. Flow diagram for updated navigation and page structureflowchart TD
subgraph Layout_default_vue
HEADER[Header_navigation_menu]
FOOTER[Footer_links]
end
subgraph Homepage_index_vue
HERO[UPageHero_with_View_GitHub_repo_and_Test_it_links]
OVERVIEW[Overview_section_describing_open_source_pipeline]
TEAM[Team_and_collaboration_section]
FUNDING[Funding_section]
end
subgraph Testing_and_download_pages
TEST_DMP[app_dmp_vue_Test_DMP_Chef]
TEST_DMP1[app_dmp1_vue_Test_DMP_Chef]
DOWNLOAD[app_download_vue_Test_DMP_Chef_download]
end
HEADER -->|GitHub_item| GITHUB_DEST[External_GitHub_repo]
HEADER -->|Test_item| TEST_DMP
HERO -->|View_GitHub_repo| GITHUB_DEST
HERO -->|Test_it| TEST_DMP
TEST_DMP --> TEST_DMP1
TEST_DMP --> DOWNLOAD
FOOTER --> COMMUNITY[Community_links_section]
OVERVIEW --> TEAM
TEAM --> FUNDING
LOGO[Logo_assets_in_public_logos] --> HERO
LOGO --> TEAM
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- The logo image on the homepage uses
src="/../public/logos/logo-dmpchef-transparent.svg", which is inconsistent with the other assets in/public/logosand may not resolve correctly; consider updating it to a root-relative path like/logos/logo-dmpchef-transparent.svg. - There are several large sections now commented out in
index.vue(features, extra cards, and a hero block); if these are no longer needed, it would be cleaner to remove them entirely or move them into a separate WIP branch/component to avoid long-term commented code in the main page.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The logo image on the homepage uses `src="/../public/logos/logo-dmpchef-transparent.svg"`, which is inconsistent with the other assets in `/public/logos` and may not resolve correctly; consider updating it to a root-relative path like `/logos/logo-dmpchef-transparent.svg`.
- There are several large sections now commented out in `index.vue` (features, extra cards, and a hero block); if these are no longer needed, it would be cleaner to remove them entirely or move them into a separate WIP branch/component to avoid long-term commented code in the main page.
## Individual Comments
### Comment 1
<location> `app/pages/index.vue:130-131` </location>
<code_context>
<div class="absolute inset-x-0 top-0 h-40 bg-gradient-to-b from-blue-300 to-white dark:from-blue-800 dark:to-transparent -z-10"></div>
+ <div class="flex flex-col items-center">
+ <div class="flex justify-center mt-30">
+ <img
+ src="/../public/logos/logo-dmpchef-transparent.svg"
+ alt="DMP Chef Logo"
+ class="h-30 w-auto"
</code_context>
<issue_to_address>
**issue (bug_risk):** Logo asset path is likely incorrect for Nuxt public/ directory usage.
Other images here use `/logos/...`, which is the standard way to reference `public/` assets in Nuxt. `src="/../public/logos/..."` may fail in production or when served from a sub-path. Please update this to use the direct public path (e.g. `src="/logos/logo-dmpchef-transparent.svg"`) for consistency and reliability.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
app/pages/index.vue
Outdated
| <img | ||
| src="/../public/logos/logo-dmpchef-transparent.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Logo asset path is likely incorrect for Nuxt public/ directory usage.
Other images here use /logos/..., which is the standard way to reference public/ assets in Nuxt. src="/../public/logos/..." may fail in production or when served from a sub-path. Please update this to use the direct public path (e.g. src="/logos/logo-dmpchef-transparent.svg") for consistency and reliability.
Summary by Sourcery
Rework the homepage and navigation to present DMP Chef as an open-source Python pipeline with clearer context, partners, and funding, and to position the web app as a test interface for the pipeline rather than the primary product.
New Features:
Enhancements: