Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ogg/vorbis files #27

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Add support for ogg/vorbis files #27

merged 2 commits into from
Aug 11, 2018

Conversation

lordwelch
Copy link
Contributor

#1

faiface
faiface requested changes Jul 27, 2018
View reviewed changes
Copy link
Owner

@faiface faiface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for this! This looks really good. One pedant thing (you see it in the review) and I think we can merge.

vorbis/decode.go Outdated
func (d *decoder) Close() error {
err := d.closer.Close()
if err != nil {
return errors.Wrap(err, "oggvorbis")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You used "ogg/vorbis" above.

@mewmew
Copy link
Contributor

mewmew commented Jul 27, 2018

Yay, this is great! Thanks for the PR @lordwelch.

@faiface
Copy link
Owner

faiface commented Aug 11, 2018

Oh, somehow forgot about this. Thanks for fixing the requested changes. Merging right now.

@faiface faiface merged commit 63cc6fb into faiface:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faiface faiface faiface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordwelch @mewmew @faiface