Open
Conversation
cebarks
requested changes
Jul 11, 2022
Collaborator
cebarks
left a comment
cebarks
left a comment
There was a problem hiding this comment.
Isn't this only needed if we beep used the multi-module workspace? I've only just started reading into the changes they introduced in 1.18 RE: multi-module workspaces but it seems like since we only have 1 main module file, nothing will change for beep.
| @@ -0,0 +1,2 @@ | |||
| *~ | |||
| go.sum | |||
Collaborator
There was a problem hiding this comment.
It's always recommened to keep go.sum in your git repo, see https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file
MarkKremer
pushed a commit
to MarkKremer/beep
that referenced
this pull request
Apr 6, 2024
add retro as project using beep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proper module support for go 1.18, otherwise things that require submodules (like generators, etc) will not be able to resolve properly in the build system.