Skip to content

Fix flake8 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Fix flake8 #273

merged 2 commits into from
Jan 25, 2019

Conversation

gyermolenko
Copy link
Contributor

As it turns out flake8 *py command checks only files by that mask in current folder, w/o going into subfolders. Fix required to also fix existing warnings.

In addition to that:

  • added # noqa to append_output.sh because multiline output string is also checked by flake8 (which is weird but it is current behavior discussed e.g. here)
  • suppressed one pytest warning regarding example TestRunner class from facade
  • modified setup.py to correspond to changes in Travis config: test with 3.7, drop 3.4, 3.5 #270 (+py37)

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #273 into master will decrease coverage by 0.02%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   69.85%   69.82%   -0.03%     
==========================================
  Files          62       62              
  Lines        2289     2287       -2     
==========================================
- Hits         1599     1597       -2     
  Misses        690      690
Impacted Files Coverage Δ
patterns/behavioral/specification.py 83.33% <ø> (ø) ⬆️
patterns/behavioral/template.py 96.66% <ø> (ø) ⬆️
patterns/behavioral/state.py 97.72% <ø> (ø) ⬆️
patterns/fundamental/delegation_pattern.py 0% <ø> (ø) ⬆️
patterns/behavioral/command.py 96.96% <ø> (ø) ⬆️
setup.py 0% <ø> (ø) ⬆️
patterns/behavioral/memento.py 0% <0%> (ø) ⬆️
patterns/structural/flyweight.py 38.33% <0%> (ø) ⬆️
patterns/behavioral/iterator.py 94.44% <100%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b253a...0731056. Read the comment docs.

@faif faif merged commit 6f12a4c into faif:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants