Skip to content

Conversation

@mshcruz
Copy link
Contributor

@mshcruz mshcruz commented Jun 13, 2017

Disclaimer: I've been looking for a project to start contributing to OSS, and this one seemed interesting and not too complicated. Since I'm a newbie in all this, any advice and suggestions are welcome! Thanks!

I intend to work on the issue "Short descriptions #184" (#184), and the first step was to include some explanation about the Factory Method pattern.
If possible, I would like some feedback on the description I added so I can have a better idea on what to do with the others.

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          61       61           
  Lines        2431     2431           
=======================================
  Hits         2303     2303           
  Misses        128      128
Impacted Files Coverage Δ
creational/factory_method.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d1dd0...c71e9a2. Read the comment docs.

@faif faif merged commit 140fabe into faif:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants