lazy evaluation: use descriptors #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as in bottle, django, pip and pyramid
Current coverage is 93.67% (diff: 90.90%)@@ master #147 diff @@
==========================================
Files 47 47
Lines 2147 2151 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2012 2015 +3
- Misses 135 136 +1
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated implementation uses a non-data descriptor to achieve the task,
as how it is done in bottlepy, django, pyramid and pip.
see also: https://gist.github.com/afg984/a2aa7e0ba4e3d908118fa6e4f44f8ac8
which includes a simple comparison & benchmark